Skip to content

refactor(multiple): clean up touch target RTL workaround #23024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

refactor(multiple): clean up touch target RTL workaround #23024

merged 1 commit into from
Jun 22, 2021

Conversation

crisbeto
Copy link
Member

We had to make some overrides to MDC's touch target styles in RTL, because they didn't align. The issue has been fixed in MDC (material-components/material-components-web#7169) so the workarounds can be cleaned up.

@crisbeto
refactor(multiple): clean up touch target RTL workaround
d431238 
We had to make some overrides to MDC's touch target styles in RTL, because they didn't align. The issue has been fixed in MDC (material-components/material-components-web#7169) so the workarounds can be cleaned up.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 19, 2021
@crisbeto crisbeto requested a review from devversion June 19, 2021 10:23
@crisbeto crisbeto requested review from andrewseguin, mmalerba and a team as code owners June 19, 2021 10:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 19, 2021
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 22, 2021
@mmalerba mmalerba merged commit cfa9a89 into angular:master Jun 22, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @andrewseguin @mmalerba